Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(model-config): loading state of extracted inputs #5445

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Nov 8, 2024

Description

This PR is large so this will be broken into bits in other PRs

The refresh of the list isn't very obvious so I added a little message (Refreshing configurations...) to show the user that its refreshing itself (while having the previous options still selectable).

Along the way I found that the fetching of all the configs was done in places that weren't necessary such as when the output updates. So I got myself into a refactor rabbit hole.

  • made some header slots better in tera-slider-panel for situations where we want more stuff in the sticky header there (now the filter is always accessible when you scroll down)
  • only fetch model once in onMounted
  • get individual model config from list instead of another api call
  • organized some functions and variables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant