Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve workflow update logging to capture more info #5189

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

mwdchang
Copy link
Member

@mwdchang mwdchang commented Oct 17, 2024

Summary

Add more logging to better debug when/where things start to get de-synced. Add

  • nodeId
  • nodeStatus
  • output values
2024-10-17 15:09:35 [INFO] REQUEST STARTED | WorkflowController.updateWorkflow | method=PUT; uri=/workflows/40ef3d97-f537-4675-89b6-ba8c3fda22a0?project-id=3d7b0bff-5c55-48b4-bc4c-0dd7aa876967;  [software.uncharted.terarium.hmiserver.interceptors.RequestLoggingInterceptor:40]
2024-10-17 15:09:35 [INFO] Node id=397a512a-af24-43fd-8dd9-ae457e4ab6df,  status=success, deleted=false [software.uncharted.terarium.hmiserver.service.data.WorkflowService:102]
2024-10-17 15:09:35 [INFO]   Out: f863d6ec-7338-48ee-b30c-2408262d21b3 [software.uncharted.terarium.hmiserver.service.data.WorkflowService:106]
2024-10-17 15:09:35 [INFO] Node id=4edc3e27-92ec-4eab-8c7d-d331d526edc2,  status=success, deleted=false [software.uncharted.terarium.hmiserver.service.data.WorkflowService:102]
2024-10-17 15:09:35 [INFO]   Out: c0bad653-6028-4847-8d08-c4260d74ab77 [software.uncharted.terarium.hmiserver.service.data.WorkflowService:106]
2024-10-17 15:09:35 [INFO] Node id=9e82c05b-519f-496b-893b-780f2c78139a,  status=success, deleted=false [software.uncharted.terarium.hmiserver.service.data.WorkflowService:102]
2024-10-17 15:09:35 [INFO]   Out: a1acd214-deac-4b0c-9d8e-16a5c86479b7 [software.uncharted.terarium.hmiserver.service.data.WorkflowService:106]
2024-10-17 15:09:35 [INFO]   Out: 3690ef26-1386-425c-b547-1db654431fab [software.uncharted.terarium.hmiserver.service.data.WorkflowService:106]
2024-10-17 15:09:35 [INFO]   Out: 7b46c5c5-884b-4c5f-b82c-9bbd5ae1cfbc [software.uncharted.terarium.hmiserver.service.data.WorkflowService:106]
2024-10-17 15:09:35 [INFO]   Out: 20c0c916-bb96-426a-ae21-c6dc0c07746c [software.uncharted.terarium.hmiserver.service.data.WorkflowService:106]
2024-10-17 15:09:35 [INFO] Node id=4e3d58f6-acb6-48d8-8125-78579c2ad82c,  status=success, deleted=false [software.uncharted.terarium.hmiserver.service.data.WorkflowService:102]
2024-10-17 15:09:35 [INFO]   Out: f863d6ec-7338-48ee-b30c-2408262d21b3 [software.uncharted.terarium.hmiserver.service.data.WorkflowService:106]
2024-10-17 15:09:35 [INFO]   Out: 60ceda1b-beec-4d1d-9b1c-24c4e9505834 [software.uncharted.terarium.hmiserver.service.data.WorkflowService:106]
2024-10-17 15:09:35 [INFO] Node id=7bea84a4-d790-4eb4-adbe-a959ad8f49d7,  status=invalid, deleted=false [software.uncharted.terarium.hmiserver.service.data.WorkflowService:102]
2024-10-17 15:09:35 [INFO]   Out: c0bad653-6028-4847-8d08-c4260d74ab77 [software.uncharted.terarium.hmiserver.service.data.WorkflowService:106]
2024-10-17 15:09:35 [INFO] Node id=2e75f889-c6e2-4b44-b132-88dd13f656d4,  status=success, deleted=true [software.uncharted.terarium.hmiserver.service.data.WorkflowService:102]
2024-10-17 15:09:35 [INFO]   Out: 60ceda1b-beec-4d1d-9b1c-24c4e9505834 [software.uncharted.terarium.hmiserver.service.data.WorkflowService:106]
2024-10-17 15:09:35 [INFO]   Out: 3fb6d158-68ef-447b-a300-605812ba6c40 [software.uncharted.terarium.hmiserver.service.data.WorkflowService:106]
2024-10-17 15:09:35 [INFO] REQUEST COMPLETED | WorkflowController.updateWorkflow | 66 ms | method=PUT; uri=/workflows/40ef3d97-f537-4675-89b6-ba8c3fda22a0?project-id=3d7b0bff-5c55-48b4-bc4c-0dd7aa876967;  [software.uncharted.terarium.hmiserver.interceptors.RequestLoggingInterceptor:78]

Copy link
Contributor

@Tom-Szendrey Tom-Szendrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never going to complain about this - thank you!

@mwdchang mwdchang merged commit f6f9052 into main Oct 17, 2024
5 checks passed
@mwdchang mwdchang deleted the improve-workflow-update-logging branch October 17, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants