Project sharing #5158
Merged
Project sharing #5158
+31
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YohannParis
requested review from
mwdchang,
jryu01,
Tom-Szendrey,
shawnyama,
blanchco and
asylves1
as code owners
Tom-Szendrey
approved these changes
Oct 17, 2024
asylves1
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5112
This pull request includes several updates to the
packages/client/hmi-clientto improve user role management, menu item labeling, and project filtering. The most important changes include adding a computed property for admin checks, updating menu item labels, and refining project filtering logic.User Role Management:
stores/auth.ts: Added a computed propertyisAdminto check if the user has an admin role.tera-navbar.vue: Updated visibility logic for user menu items to use the newisAdminproperty.Menu Item Labeling:
tera-project-menu.vue: Updated labels for menu items (renameMenuItemtoeditDetailsMenuItem,removeMenuItemtodeleteMenuItem, andcopyMenuItemtocopy).Project Filtering:
Home.vue: Refined the filtering logic to include projects that the user can edit or view if they are not public.Miscellaneous:
Home.vue: Cleaned up the template code by removing commented-out sections.tera-project-menu.vue: Removed theseparatorMenuItemand adjusted the logic for adding menu items based on user permissions and admin status.