Model extractions update #5127
Merged
Model extractions update #5127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YohannParis
requested review from
mwdchang,
jryu01,
Tom-Szendrey,
shawnyama,
blanchco,
asylves1 and
dgauldie
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the
knowledge.tsservice file and a documentation update. The most important changes involve code cleanup, restructuring imports, and updating a manual test scenario.Code cleanup and restructuring:
packages/client/hmi-client/src/services/knowledge.ts: Removed multipleconsole.debugstatements and unnecessaryconsole.groupcalls to clean up the code.packages/client/hmi-client/src/services/knowledge.ts: Deleted thecodeToAMRandcodeBlocksToAmrfunctions, which were no longer needed.packages/client/hmi-client/src/services/knowledge.ts: Restructured imports for better readability, including movingAxiosResponseimport to the top and combining type imports.Documentation update:
testing/manual/model-from-equations.md: Renamed the file frommodel-extraction.mdtomodel-from-equations.mdand updated the test scenario steps to reflect the new workflow and ensure clarity. [1] [2]