Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: funman graph improvements #5105

Merged
merged 12 commits into from
Oct 16, 2024
Merged

feat: funman graph improvements #5105

merged 12 commits into from
Oct 16, 2024

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Oct 9, 2024 •
edited
Loading

Description

  • Prevent constants from being picked in parameters of interest
  • Only show parameter graphs of interest
  • Add ambiguous boxes
  • The latest timepoint should be shown not the furthest one specified
    • By default I am showing all boxes and there is a checkbox to just see the latest one
  • Add option to prioritize the view of the model check

image

@shawnyama shawnyama marked this pull request as ready for review October 9, 2024 19:51
mwdchang
mwdchang approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@mwdchang mwdchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go!

@shawnyama shawnyama merged commit 7619294 into main Oct 16, 2024
4 checks passed
@shawnyama shawnyama deleted the funman-graph-improvements branch October 16, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YohannParis YohannParis YohannParis approved these changes

@mwdchang mwdchang mwdchang approved these changes

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

@asylves1 asylves1 Awaiting requested review from asylves1 asylves1 is a code owner

Assignees

@jryu01 jryu01

@Tom-Szendrey Tom-Szendrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shawnyama @YohannParis @mwdchang @jryu01 @Tom-Szendrey