Add workflowid to notebooksession and create proper migration from na…

…me (#3731)
DARPA-ASKEM · Jun 4, 2024 · 82de5d7 · 82de5d7
1 parent 5ab81ff
commit 82de5d7
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 10 deletions.
diff --git a/packages/client/hmi-client/src/components/llm/tera-jupyter-chat.vue b/packages/client/hmi-client/src/components/llm/tera-jupyter-chat.vue
@@ -404,7 +404,6 @@ watch(
  if (props.notebookSession) {
  await updateNotebookSession({
  id: props.notebookSession.id,
- name: props.notebookSession.name,
  description: props.notebookSession.description,
  data: { history: notebookItems.value }
  });

diff --git a/...t/hmi-client/src/components/workflow/ops/dataset-transformer/tera-dataset-transformer.vue b/...t/hmi-client/src/components/workflow/ops/dataset-transformer/tera-dataset-transformer.vue
@@ -59,7 +59,6 @@ onMounted(async () => {
  // create a new notebook session log if it does not exist
  const response = await createNotebookSession({
  id: uuidv4(),
- name: props.node.id,
  description: '',
  data: { history: [] }
  });

diff --git a/...lient/hmi-client/src/components/workflow/ops/model-transformer/tera-model-transformer.vue b/...lient/hmi-client/src/components/workflow/ops/model-transformer/tera-model-transformer.vue
@@ -58,7 +58,6 @@ onMounted(async () => {
  // create a new notebook session log if it does not exist
  const response = await createNotebookSession({
  id: uuidv4(),
- name: props.node.id,
  description: '',
  data: { history: [] }
  });

diff --git a/packages/client/hmi-client/src/components/workflow/ops/regridding/tera-regridding.vue b/packages/client/hmi-client/src/components/workflow/ops/regridding/tera-regridding.vue
@@ -50,7 +50,6 @@ onMounted(async () => {
  // create a new notebook session log if it does not exist
  const response = await createNotebookSession({
  id: uuidv4(),
- name: props.node.id,
  description: '',
  data: { history: [] }
  });

diff --git a/packages/client/hmi-client/src/services/notebook-session.ts b/packages/client/hmi-client/src/services/notebook-session.ts
@@ -14,7 +14,6 @@ export const getNotebookSessionById = async (notebook_id: string) => {
 export const createNotebookSession = async (notebookSession: NotebookSession) => {
  const response = await API.post(`/sessions`, {
  id: notebookSession.id,
- name: notebookSession.name,
  description: notebookSession.description,
  data: notebookSession.data
  } as NotebookSession);
@@ -24,7 +23,6 @@ export const createNotebookSession = async (notebookSession: NotebookSession) =>
 export const updateNotebookSession = async (notebookSession: NotebookSession) => {
  const response = await API.put(`/sessions/${notebookSession.id}`, {
  id: notebookSession.id,
- name: notebookSession.name,
  description: notebookSession.description,
  data: notebookSession.data
  });

diff --git a/...ware/uncharted/terarium/hmiserver/models/dataservice/notebooksession/NotebookSession.java b/...ware/uncharted/terarium/hmiserver/models/dataservice/notebooksession/NotebookSession.java
@@ -22,15 +22,14 @@ public class NotebookSession extends TerariumAsset {
  @Serial
  private static final long serialVersionUID = 9176019416379347233L;
 
- // TODO: https://github.com/DARPA-ASKEM/terarium/issues/3719
- // private UUID workflowId;
-
  @Type(JsonType.class)
  @Column(columnDefinition = "json")
  private JsonNode data;
 
+ @Override
  public NotebookSession clone() {
- NotebookSession session = new NotebookSession();
+ final NotebookSession session = new NotebookSession();
+ super.cloneSuperFields(session);
  session.setData(data.deepCopy());
  return session;
  }