Skip to content

Commit

Permalink
fix simulate preset selection not triggering update (#4921)
Browse files Browse the repository at this point in the history
  • Loading branch information
mwdchang authored Sep 25, 2024
1 parent 1aeb7a4 commit 1538ab2
Showing 1 changed file with 15 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -255,11 +255,11 @@ const codeText = ref('');
const policyInterventionId = computed(() => props.node.inputs[1].value?.[0]);
const interventionPolicy = ref<InterventionPolicy | null>(null);
const timespan = ref<TimeSpan>(props.node.state.currentTimespan);
const llmThoughts = ref<any[]>([]);
const llmQuery = ref('');
// extras
// input params
const timespan = ref<TimeSpan>(props.node.state.currentTimespan);
const numSamples = ref<number>(props.node.state.numSamples);
const method = ref(props.node.state.method);
Expand All @@ -268,12 +268,12 @@ enum OutputView {
Data = 'Data'
}
const speedValues = Object.freeze({
const speedPreset = Object.freeze({
numSamples: 10,
method: CiemssMethodOptions.euler
});
const qualityValues = Object.freeze({
const qualityPreset = Object.freeze({
numSamples: 100,
method: CiemssMethodOptions.dopri5
});
Expand Down Expand Up @@ -315,10 +315,10 @@ const outputs = computed(() => {
});
const presetType = computed(() => {
if (numSamples.value === speedValues.numSamples && method.value === speedValues.method) {
if (numSamples.value === speedPreset.numSamples && method.value === speedPreset.method) {
return CiemssPresetTypes.Fast;
}
if (numSamples.value === qualityValues.numSamples && method.value === qualityValues.method) {
if (numSamples.value === qualityPreset.numSamples && method.value === qualityPreset.method) {
return CiemssPresetTypes.Normal;
}
Expand All @@ -338,13 +338,14 @@ const chartProxy = chartActionsProxy(props.node, (state: SimulateCiemssOperation
const setPresetValues = (data: CiemssPresetTypes) => {
if (data === CiemssPresetTypes.Normal) {
numSamples.value = qualityValues.numSamples;
method.value = qualityValues.method;
numSamples.value = qualityPreset.numSamples;
method.value = qualityPreset.method;
}
if (data === CiemssPresetTypes.Fast) {
numSamples.value = speedValues.numSamples;
method.value = speedValues.method;
numSamples.value = speedPreset.numSamples;
method.value = speedPreset.method;
}
updateState();
};
const groupedInterventionOutputs = computed(() => _.groupBy(interventionPolicy.value?.interventions, 'appliedTo'));
Expand Down Expand Up @@ -413,18 +414,16 @@ const run = async () => {
const makeForecastRequest = async () => {
const modelConfigId = props.node.inputs[0].value?.[0];
const state = props.node.state;
const payload: SimulationRequest = {
modelConfigId,
timespan: {
start: state.currentTimespan.start,
end: state.currentTimespan.end
start: timespan.value.start,
end: timespan.value.end
},
extra: {
solver_method: state.method,
solver_method: method.value,
solver_step_size: 1,
num_samples: state.numSamples
num_samples: numSamples.value
},
engine: 'ciemss'
};
Expand Down

0 comments on commit 1538ab2

Please sign in to comment.