Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: cloud builder for multi arch builds #163

Merged
merged 6 commits into from
Feb 13, 2024
Merged

ci: cloud builder for multi arch builds #163

merged 6 commits into from
Feb 13, 2024

Conversation

Nithos
Copy link
Contributor

@Nithos Nithos commented Feb 13, 2024

Enabling cloud building of multi arch images using docker cloud builder. This uses the reusable workflow that connects to the cloud builder, builds the images and pushes directly to the existing registry (GHCR).

Please note that the cloud builder is still considered experimental and is limited to it's own set of limited CI minutes (separate from GH CI). Use sparingly.

As before workflow is triggered on merges to main and tags

Some minor changes to the bake file were made as the target name is used as part of the image name now, so this was changed to match the existing naming convention of the image.

update bakefile targets as they are used for image naming
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (50823b8) 84.26% compared to head (f03b740) 84.26%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #163   +/-   ##
=======================================
  Coverage   84.26%   84.26%           
=======================================
  Files           4        4           
  Lines         661      661           
=======================================
  Hits          557      557           
  Misses        104      104           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nithos Nithos changed the title ci: cloud builder test ci: cloud builder for multi arch builds Feb 13, 2024
@@ -28,26 +28,30 @@ function "check_suffix" {
# ----------------------------------------------------------------------------------------------------------------------

group "prod" {
targets = ["sciml-service"]
targets = ["simulation-service"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come you changed to simulation-service?

@Nithos Nithos requested a review from fivegrant February 13, 2024 14:13
@Nithos Nithos marked this pull request as ready for review February 13, 2024 14:13
@Nithos Nithos merged commit 2b95c4c into main Feb 13, 2024
6 checks passed
@Nithos Nithos deleted the cloud-builder branch February 13, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants