#2154: Explore use of `std::chrono` for `TimeType` #2170

JacobDomagala · 2023-06-21T14:33:37Z

JacobDomagala · 2023-06-21T14:35:37Z

This branch for now consists of changes from https://github.com/DARMA-tasking/vt/tree/2168-use-loadtype-in-lb and https://github.com/DARMA-tasking/vt/tree/2150-use-strong-time-type with addition of using std::chrono for TimeType.

Work related to std::chrono was made in following commits:

github-actions · 2023-11-14T00:13:43Z

Pipelines results

PR tests (gcc-12, ubuntu, mpich)

Build for 0afa389 (2023-12-20 23:47:03 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-9, ubuntu, mpich)

Build for 4f09de6 (2024-09-03 16:42:42 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, ubuntu, mpich)

Build for 4f09de6 (2024-09-03 16:42:42 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-12, ubuntu, mpich)

Build for 4f09de6 (2024-09-03 16:42:42 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-11, ubuntu, mpich)

Build for 4f09de6 (2024-09-03 16:42:42 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan, json schema test)

Build for 4f09de6 (2024-09-03 16:42:42 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 4f09de6 (2024-09-03 16:42:42 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-14, ubuntu, mpich)

Build for 0afa389 (2023-12-20 23:47:03 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage)

Build for 4f09de6 (2024-09-03 16:42:42 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-10, ubuntu, mpich)

Build for 4f09de6 (2024-09-03 16:42:42 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 4f09de6 (2024-09-03 16:42:42 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (intel icpc, ubuntu, mpich)

Build for 4f09de6 (2024-09-03 16:42:42 UTC)

remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhi%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log

PR tests (nvidia cuda 11.2, gcc-9, ubuntu, mpich)

Build for 4f09de6 (2024-09-03 16:42:42 UTC)

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]"
          detected during:
            instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]" 
/vt/src/vt/objgroup/proxy/proxy_objgroup.impl.h(221): here
            instantiation of "vt::objgroup::proxy::Proxy<ObjT>::PendingSendType vt::objgroup::proxy::Proxy<ObjT>::reduce<f,Op,Target,Args...>(Target, Args &&...) const [with ObjT=vt::vrt::collection::lb::GreedyLB, f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Op=vt::collective::PlusOp, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>, Args=<vt::vrt::collection::lb::GreedyPayload>]" 
/vt/src/vt/vrt/collection/balance/greedylb/greedylb.cc(222): here

/vt/src/vt/runtime/component/diagnostic_value.h(249): warning: missing return statement at end of non-void function "vt::runtime::component::detail::DiagnosticValueWrapper<T>::getComputedValue [with T=vt::diagnostic::CounterDefaultType]"
          detected during instantiation of "T vt::runtime::component::detail::DiagnosticValueWrapper<T>::getComputedValue() const [with T=vt::diagnostic::CounterDefaultType]" 
/vt/src/vt/runtime/component/diagnostic_value.cc(112): here

/vt/src/vt/runtime/component/diagnostic_value.h(249): warning: missing return statement at end of non-void function "vt::runtime::component::detail::DiagnosticValueWrapper<T>::getComputedValue [with T=double]"
          detected during instantiation of "T vt::runtime::component::detail::DiagnosticValueWrapper<T>::getComputedValue() const [with T=double]" 
/vt/src/vt/runtime/component/diagnostic_value.cc(113): here

/vt/src/vt/runtime/component/diagnostic_value.h(249): warning: missing return statement at end of non-void function "vt::runtime::component::detail::DiagnosticValueWrapper<T>::getComputedValue [with T=vt::diagnostic::TimerDefaultType]"
          detected during instantiation of "T vt::runtime::component::detail::DiagnosticValueWrapper<T>::getComputedValue() const [with T=vt::diagnostic::TimerDefaultType]" 
/vt/src/vt/runtime/component/diagnostic_value.cc(114): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]" 
/vt/examples/callback/callback.cc%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log

PR tests (clang-13, alpine, mpich)

Build for 4f09de6 (2024-09-03 16:42:42 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (intel icpx, ubuntu, mpich, verbose)

Build for 4f09de6 (2024-09-03 16:42:42 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-12, ubuntu, mpich, verbose, kokkos)

Build for 4f09de6 (2024-09-03 16:42:42 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-14, ubuntu, mpich, verbose)

Build for 4f09de6 (2024-09-03 16:42:42 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 12.2.0, gcc-9, ubuntu, mpich, verbose)

Build for 4f09de6 (2024-09-03 16:42:42 UTC)

/vt/lib/CLI/CLI/CLI11.hpp(1029): warning #2361-D: invalid narrowing conversion from "double" to "unsigned long"
          TT { std::declval<CC>() }
               ^
          detected during:
            instantiation of "vt::CLI::detail::is_direct_constructible<T, C>::test [with T=std::vector<std::string, std::allocator<std::string>>, C=double]" based on template arguments <std::vector<std::string, std::allocator<std::string>>, double> at line 1041
            instantiation of class "vt::CLI::detail::is_direct_constructible<T, C> [with T=std::vector<std::string, std::allocator<std::string>>, C=double]" at line 5005
            instantiation of "void vt::CLI::Option::results(T &) const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 5034
            instantiation of "T vt::CLI::Option::as<T>() const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 7315

Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"

/vt/lib/CLI/CLI/CLI11.hpp(1029): warning #2361-D: invalid narrowing conversion from "int" to "unsigned long"
          TT { std::declval<CC>() }
               ^
          detected during:
            instantiation of "vt::CLI::detail::is_direct_constructible<T, C>::test [with T=std::vector<std::string, std::allocator<std::string>>, C=int]" based on template arguments <std::vector<std::string, std::allocator<std::string>>, int> at line 1041
            instantiation of class "vt::CLI::detail::is_direct_constructible<T, C> [with T=std::vector<std::string, std::allocator<std::string>>, C=int]" at line 5005
            instantiation of "void vt::CLI::Option::results(T &) const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 5034
            instantiation of "T vt::CLI::Option::as<T>() const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 7315

/vt/tests/perf/send_cost.cc(169): warning #177-D: variable "prevNode" was declared but never referenced
    auto const prevNode = (thisNode - 1 + num_nodes_) % num_nodes_;
               ^

Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"

Testing - passed

Build log

lifflander

Looks good to me

JacobDomagala force-pushed the 2154-explore-use-of-std-chrono-for-timetype branch 2 times, most recently from ecc6b9e to 362f533 Compare November 13, 2023 23:28

JacobDomagala marked this pull request as ready for review November 14, 2023 10:08

JacobDomagala force-pushed the 2154-explore-use-of-std-chrono-for-timetype branch 2 times, most recently from 65e7938 to b77dc14 Compare November 14, 2023 13:28

JacobDomagala requested review from lifflander, nmm0, thearusable and nlslatt November 15, 2023 11:46

JacobDomagala force-pushed the 2154-explore-use-of-std-chrono-for-timetype branch from b77dc14 to f0996ca Compare November 21, 2023 17:28

JacobDomagala marked this pull request as draft November 21, 2023 17:30

JacobDomagala removed request for lifflander, nmm0, thearusable and nlslatt November 21, 2023 17:30

JacobDomagala marked this pull request as ready for review November 24, 2023 08:28

JacobDomagala force-pushed the 2154-explore-use-of-std-chrono-for-timetype branch from f0996ca to 145f344 Compare November 24, 2023 08:28

JacobDomagala requested review from stmcgovern, lifflander, nmm0, thearusable and nlslatt November 24, 2023 11:02

JacobDomagala force-pushed the 2154-explore-use-of-std-chrono-for-timetype branch 2 times, most recently from d5fdfe4 to ca4de2e Compare December 19, 2023 12:01

lifflander approved these changes Dec 19, 2023

View reviewed changes

JacobDomagala force-pushed the 2154-explore-use-of-std-chrono-for-timetype branch from ca4de2e to 0afa389 Compare December 20, 2023 23:47

JacobDomagala self-assigned this Jan 16, 2024

JacobDomagala force-pushed the 2154-explore-use-of-std-chrono-for-timetype branch from 0afa389 to 91421ca Compare August 27, 2024 16:55

JacobDomagala force-pushed the 2154-explore-use-of-std-chrono-for-timetype branch from 91421ca to f13c508 Compare August 28, 2024 15:10

JacobDomagala added 2 commits September 3, 2024 18:42

#2154: Use std::chrono for TimeType

a6e755c

#2154: Add static_assert for checking whether TimeType is byte_copyable

4f09de6

JacobDomagala force-pushed the 2154-explore-use-of-std-chrono-for-timetype branch from f13c508 to 4f09de6 Compare September 3, 2024 16:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#2154: Explore use of `std::chrono` for `TimeType` #2170

#2154: Explore use of `std::chrono` for `TimeType` #2170

JacobDomagala commented Jun 21, 2023

JacobDomagala commented Jun 21, 2023 •

edited

Loading

github-actions bot commented Nov 14, 2023 •

edited

Loading

lifflander left a comment

#2154: Explore use of std::chrono for TimeType #2170

Are you sure you want to change the base?

#2154: Explore use of std::chrono for TimeType #2170

Conversation

JacobDomagala commented Jun 21, 2023

JacobDomagala commented Jun 21, 2023 • edited Loading

github-actions bot commented Nov 14, 2023 • edited Loading

Pipelines results

lifflander left a comment

Choose a reason for hiding this comment

#2154: Explore use of `std::chrono` for `TimeType` #2170

#2154: Explore use of `std::chrono` for `TimeType` #2170

JacobDomagala commented Jun 21, 2023 •

edited

Loading

github-actions bot commented Nov 14, 2023 •

edited

Loading