Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#21: Add Kokkos dependency for magistrate #22

Merged
merged 6 commits into from
Aug 7, 2024
Merged

#21: Add Kokkos dependency for magistrate #22

merged 6 commits into from
Aug 7, 2024

Conversation

JacobDomagala
Copy link
Contributor

Fixes #21

@JacobDomagala JacobDomagala self-assigned this Aug 1, 2024
@JacobDomagala JacobDomagala linked an issue Aug 1, 2024 that may be closed by this pull request
add optional Kokkos support to magistrate #21
Closed
@JacobDomagala JacobDomagala force-pushed the 21-add-optional-kokkos-support-to-magistrate branch from b1fa73b to 0cb4585 Compare August 1, 2024 20:00
@JacobDomagala JacobDomagala force-pushed the 21-add-optional-kokkos-support-to-magistrate branch from 0cb4585 to fe22924 Compare August 1, 2024 20:14
@JacobDomagala JacobDomagala marked this pull request as ready for review August 1, 2024 20:25
@JacobDomagala
Copy link
Contributor Author

@cz4rs @nmm0 Let me know if that works for you. I don't use Spack so not sure whether you want to build everything from scratch or you'd rather use existing Kokkos installation.

cz4rs
cz4rs approved these changes Aug 2, 2024
View reviewed changes
Copy link

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty reasonable to me. Minimal experience with Spack here though 😉

@JacobDomagala JacobDomagala force-pushed the 21-add-optional-kokkos-support-to-magistrate branch 8 times, most recently from 8318e77 to fc692a8 Compare August 2, 2024 22:17
@JacobDomagala JacobDomagala force-pushed the 21-add-optional-kokkos-support-to-magistrate branch from fc692a8 to 058e235 Compare August 2, 2024 22:18
@JacobDomagala
Copy link
Contributor Author

Ok finally got it working. Currently it uses latest release (v4.3.01), should we pin it to 4.1.0?

@cz4rs
Copy link

cz4rs commented Aug 5, 2024

Ok finally got it working. Currently it uses latest release (v4.3.01), should we pin it to 4.1.0?

I think latest is fine, users can specify the version they want anyways. I was only surprised with the 3.2.0.

lifflander
lifflander approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@lifflander lifflander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

nmm0
nmm0 approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@nmm0 nmm0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Only a minor comment is we could rename kokkos_enabled to just kokkos since that's in line with other spack packages

@nmm0 nmm0 merged commit b9b7490 into master Aug 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmm0 nmm0 nmm0 approved these changes

@cz4rs cz4rs cz4rs approved these changes

@lifflander lifflander lifflander approved these changes

Assignees

@JacobDomagala JacobDomagala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add optional Kokkos support to magistrate
4 participants
@JacobDomagala @cz4rs @lifflander @nmm0