-
-
Notifications
You must be signed in to change notification settings - Fork 51
feat: add support for component's evidences according to spec #810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for providing this feature, @OxPirates could you
|
@jkowalleck Thank you for your time, Will work on it and submit the changes. |
@jkowalleck Thank you for the detailed review. All comments have been addressed except the one regarding ToolReference |
Signed-off-by: Arun <[email protected]>
the amend/squash of the changes makes review hard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please move all these new symbols to an own module called component_evidence
.
Thanks in advance
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
did that for you. will continue the review |
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Arun <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
@OxPirates, i fixed the normalizers implementation so that it also works for multiple identities in CycloneDX 1.5 XML. CI/CT fails, since the implementation of the serialization library needs a little tweak - will add this soon. PS: fixed and created madpah/serializable#172 |
Signed-off-by: Jan Kowalleck <[email protected]>
@OxPirates I think we have a solid implementation, now. |
Signed-off-by: Jan Kowalleck <[email protected]>
Yes, Alredy doing so.. |
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Can we promote this change now? |
sure. I was just waiting for your review. |
Yes, Please go ahead, No further comment |
this feature was released in https://github.com/CycloneDX/cyclonedx-python-lib/releases/tag/v10.2.0 |
fixes #737