Skip to content

Commit

Permalink
style: fix codacy warnings
Browse files Browse the repository at this point in the history
Signed-off-by: Jeremy Long <[email protected]>
  • Loading branch information
jeremylong committed Dec 18, 2024
1 parent 6fc6935 commit 152b3c3
Showing 1 changed file with 18 additions and 14 deletions.
32 changes: 18 additions & 14 deletions lib/cyclonedx/cocoapods/bom_builder.rb
Original file line number Diff line number Diff line change
Expand Up @@ -345,27 +345,31 @@ def initialize(pods:, manifest_path:, component: nil, dependencies: nil, manufac
end

def bom(version: 1, trim_strings_length: 0, format: :xml)
validate_bom_args(version, trim_strings_length, format)
validate_version(version)
validate_trim_length(trim_strings_length)
validate_format(format)

unchecked_bom(version: version, trim_strings_length: trim_strings_length, format: format)
end

private

def validate_bom_args(version, trim_strings_length, format)
unless version.to_i.positive?
raise ArgumentError,
"Incorrect version: #{version} should be an integer greater than 0"
end
def validate_version(version)
return if version.to_i.positive?

unless trim_strings_length.is_a?(Integer) && (trim_strings_length.positive? || trim_strings_length.zero?)
raise ArgumentError,
"Incorrect string length: #{trim_strings_length} should be an integer greater than 0"
end
raise ArgumentError, "Incorrect version: #{version} should be an integer greater than 0"
end

unless %i[xml json].include?(format)
raise ArgumentError,
"Incorrect format: #{format} should be either :xml or :json"
end
def validate_trim_length(trim_strings_length)
return if trim_strings_length.is_a?(Integer) && (trim_strings_length.positive? || trim_strings_length.zero?)

raise ArgumentError, "Incorrect string length: #{trim_strings_length} should be an integer greater than 0"
end

def validate_format(format)
return if %i[xml json].include?(format)

raise ArgumentError, "Incorrect format: #{format} should be either :xml or :json"
end

# does not verify parameters because the public method does that.
Expand Down

0 comments on commit 152b3c3

Please sign in to comment.