Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker version #51

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Docker version #51

wants to merge 7 commits into from

Conversation

AlexNik
Copy link

@AlexNik AlexNik commented Apr 29, 2021

Move code to classes
Add command line arguments
Add Docker feature

@AlexNik
Copy link
Author

AlexNik commented May 1, 2021

@CyberPunkMetalHead What do you think?



if __name__ == '__main__':
argument_parser = ArgumentParser('Binance news sentiment bot.', formatter_class=ArgumentDefaultsHelpFormatter)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add docker commands and arguments in the README file? I would like to try this on local.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rushabhshah011 You are welcome)

@AlexNik
Copy link
Author

AlexNik commented May 7, 2021

@Rybens92 @petar-petkov @CyberPunkMetalHead any reaction?
Are you going to merge it?

@CyberPunkMetalHead
Copy link
Owner

Hey @AlexNik, should be able to review your code in the next couple of days. Though I'm seeing a conflict with the main file?

@AlexNik
Copy link
Author

AlexNik commented May 9, 2021

@CyberPunkMetalHead ok, I'll solve conflicts

Rybens92 and others added 4 commits May 11, 2021 01:37
* save and load coins_in_hand dictionary to/from json file

* remove not needed comment
# Conflicts:
#	news-analysis.py
@AlexNik
Copy link
Author

AlexNik commented May 31, 2021

@CyberPunkMetalHead Any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants