Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get mean #159

Merged
merged 2 commits into from
Dec 27, 2023
Merged

get mean #159

merged 2 commits into from
Dec 27, 2023

Conversation

nomuramasahir0
Copy link
Collaborator

getter for mean vector

@nomuramasahir0
Copy link
Collaborator Author

@c-bata Can you review this?

c-bata
c-bata approved these changes Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we also add the mean property to SepCMA class?

@nomuramasahir0
Copy link
Collaborator Author

Certainly, I added it!

@nomuramasahir0 nomuramasahir0 merged commit 057798d into main Dec 27, 2023
12 checks passed
@nomuramasahir0 nomuramasahir0 deleted the feature-get-mean branch December 27, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-bata c-bata c-bata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nomuramasahir0 @c-bata