Add reload logic to collector container start script. #4099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: PGO-2196
benjaminjb
reviewed
Feb 20, 2025
| } | ||
|
|
||
| var startScript = fmt.Sprintf(` | ||
| OTEL_PIDFILE=/tmp/otel.pid |
There was a problem hiding this comment.
Does the otelcontrib process have a name? Or did we want the PID to check if it's running (without recourse to pgrep)?
There was a problem hiding this comment.
I'm honestly not sure of the best way to do this. I used some prior art in our codebase as a starting point
cbandy
reviewed
Feb 20, 2025
|
|
||
| exec {fd}<> <(:||:) | ||
| while read -r -t 5 -u "${fd}" ||:; do | ||
| logrotate -s /tmp/logrotate.status /etc/logrotate.d/logrotate.conf | ||
| %s | ||
| if [[ "${directory}" -nt "/proc/self/fd/${fd}" ]] && kill -HUP $(head -1 ${OTEL_PIDFILE?}); |
There was a problem hiding this comment.
🤔 What happens if Bash is terminated? Is the entire container torn down, including the collector?
If so, we can keep the collector pid in a variable in memory.
# start
otel ... &
OTEL_PID=$!
# here
kill -HUP ${OTEL_PID}
# below
[[ ! -e /proc/${OTEL_PID} ]]
Comment on lines
-157
to
+167
| logrotate -s /tmp/logrotate.status /etc/logrotate.d/logrotate.conf | ||
| %s |
There was a problem hiding this comment.
🌱 Perhaps this could always be [[ -r /etc/logrotate.d/logrotate.conf ]] && logrotate ... and the choice to rotate or not would be at the mounting of the config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: PGO-2196
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
The OTel Collector process does not reload when changes are made to its configuration.
What is the new behavior (if this is a feature change)?
The OTel Collector process will now be sent a SIGHUP signal to reload its configuration when a change is made to the config directory.
Other Information: