[SCRUN-1] add pre commit hook #467
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aless10
changed the title
aless10
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wants to add pre-commit hooks to improve the codebase and checks for errors.
This is intended to be run using python3.11 so that we start moving to a newer version of python.
However, the precommit hooks does not change the files in a way that the py2 version is not working.
How to reproduce:
pip install pre-commitpre-commit installpre-commit run --all-filesto see that the hook is workingThere are some checks that are run during commit:
On push, we run the tests with pytest.
I am going to create another PR to fix all the error that are highlighted when running pre-commit run --all-files.