Skip to content

Conversation

mathiasbc
Copy link
Contributor

…ges. They still exists but their behaviour is directly inherited from the Dataset class, which makes them identical at this point

…ges. They still exists but their behaviour is directly inherited from the Dataset class, which makes them identical at this point
@jamesrkg
Copy link

jamesrkg commented Nov 15, 2019

How does the scrunch.dataset.LOG work? We also use a logger but the deprecation warning is not coming up. It might be better to raise a DeprecationWarning in a simpler way to ensure its visible to all users, in addition to sending it to your logger.

@jamesrkg
Copy link

I think Dataset would benefit from:

@property
def streaming(self):
    return self.resource.body.get('streaming', 'no')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants