[MPDX-8759/MPDX-8764] Load and modify goal calculations #1413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview branch generated at https://8759-load-goal-calculations.d3dytjb8adxkk5.amplifyapp.com |
3 tasks
dr-bizz
approved these changes
Aug 21, 2025
Comment on lines
+124
to
+129
| update: (cache) => { | ||
| cache.evict({ id: `GoalCalculation:${goal.id}` }); | ||
| cache.gc(); | ||
| }, | ||
| }); | ||
| setDeleting(false); |
There was a problem hiding this comment.
Lets add snackbar to this so the user is updated if it's successful or there is an error
There was a problem hiding this comment.
Quoting my other comment:
The GraphQL client automatically shows a snackbar message if there was an error. I know in some places we show a snackbar message on errors, but that actually results in 2 snackbar messages popping up.
I'm not strongly opposed to adding a success message. Although my initial thought is that seeing the goal calculation disappear from the list is sufficient to tell the user that it was deleted.
dr-bizz
approved these changes
Aug 21, 2025
Bundle sizes [mpdx-react]Compared against e8281a8
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the goals list and cards to use real data from the GraphQL API.
The starred / primary is in the design, but it is a post-MVP feature, so I removed the star from being rendered for now. I kept in the codebase so that it's possible to test and so that it's easy to turn back on when we're ready.
It also renders the date as the title since we don't have a name field for goal calculations yet (Zach is working on this).
Depends on https://github.com/CruGlobal/mpdx_api/pull/2969 and https://github.com/CruGlobal/mpdx_api/pull/2983
MPDX-8759 and MPDX-8764
Checklist: