Skip to content

Conversation

@levieggertcru
Copy link
Collaborator

No description provided.

@levieggertcru levieggertcru marked this pull request as draft May 20, 2025 16:34
@levieggertcru levieggertcru requested a review from frett May 20, 2025 16:34
@levieggertcru
Copy link
Collaborator Author

So far was able to build and run the project. @frett is looking into next path forward to resolve an Exception.

"Uncaught Kotlin exception: kotlin.IllegalStateException: Error: Info.plist doesn't have a valid CADisableMinimumFrameDurationOnPhone entry.
This will result in an inadequate performance on iPhones with high refresh rate.
Add <key>CADisableMinimumFrameDurationOnPhone</key><true/> entry to Info.plist to fix this error.
If you don't have a separate plist file, add the entry to the target from within Xcode: Project -> Targets -> Info -> Custom iOS Target Properties.
Or set ComposeUIViewController(configure = { enforceStrictPlistSanityCheck = false }) { .. }, if it's intended. "

@codecov
Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 868 lines in your changes missing coverage. Please review.

Project coverage is 40.20%. Comparing base (c66713f) to head (5874390).

Files with missing lines Patch % Lines
...ws/ContentStack/LegacyMobileContentStackView.swift 0.00% 835 Missing ⚠️
...nt/Views/ContentStack/MobileContentStackView.swift 0.00% 33 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2623      +/-   ##
===========================================
- Coverage    40.25%   40.20%   -0.06%     
===========================================
  Files         1195     1196       +1     
  Lines        60013    60071      +58     
===========================================
- Hits         24160    24152       -8     
- Misses       35853    35919      +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gitguardian
Copy link

gitguardian bot commented Oct 17, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
21305979 Triggered Facebook App Keys caa8e4e godtools/App/AppConfig/GodToolsAppConfig.swift View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants