Skip to content

GT-1586 Add native URLSessionWebSocketTask to replace Starscream dependency #2524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 4, 2025

Conversation

levieggertcru
Copy link
Collaborator

@levieggertcru levieggertcru commented Apr 1, 2025

Starting to add URLSessionWebSocketTask to replace dependency Starscream for the tract screen share.

Also changed action cable scheme to use wss instead of https per apple docs (https://developer.apple.com/documentation/foundation/urlsessionwebsockettask#overview)

Some nuances with URLSessionWebSocketTask.

  • Needed to continually ping the socket to keep alive.
  • The URLSessionWebSocketTask receive closure is called once per message received. So need to continually set the closure after receiving a message.

I plan to create some follow up tasks with this.

  • One to replace the Signals with Combine Publishers and add some better error handling.
  • Another task to remove Starscream once this passes QA.

@levieggertcru levieggertcru marked this pull request as draft April 1, 2025 18:03
@levieggertcru levieggertcru changed the title GT-1586 Native URLSessionWebSocketTask to replace Starscream dependency GT-1586 Add native URLSessionWebSocketTask to replace Starscream dependency Apr 1, 2025
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.07%. Comparing base (e31f975) to head (21c2620).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2524   +/-   ##
========================================
  Coverage    96.07%   96.07%           
========================================
  Files           63       63           
  Lines         5528     5528           
========================================
  Hits          5311     5311           
  Misses         217      217           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@levieggertcru levieggertcru marked this pull request as ready for review April 2, 2025 19:51
@levieggertcru levieggertcru merged commit cb509bc into develop Apr 4, 2025
4 checks passed
@levieggertcru levieggertcru deleted the GT-1586-add-url-session-web-socket-task branch April 4, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant