Fixes for Rails 7, Sidekiq 7 #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knutsenm
approved these changes
Jun 10, 2025
Contributor
knutsenm
left a comment
knutsenm
left a comment
There was a problem hiding this comment.
Approved, with suggestion
knutsenm
approved these changes
Jun 10, 2025
Contributor
knutsenm
left a comment
knutsenm
left a comment
There was a problem hiding this comment.
Approved, with (corrected) suggestion
Co-authored-by: Mark Knutsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some Rails 7.1 fixes in here (
to_fs).Also, Sidekiq 7+ uses the
redis-clientgem (more lightweight) instead of theredisgem, and themock_redisgem is incompatible. The maintainer ofredis-clientsuggests that you shouldn't mock it since it's much easier to just add to your CI these days, and none of the mocking scenarios listed are valid here, so I just removed themock_redisgem.I'm making the dependencies a bit more strict here since I'm not sure how many of the changes are backwards compatible.