Adds build job to needs list for safer deploy

[zweatshirt]

• Adds build job to deploy dependencies/needs list. Deploy should not occur if build fails. Deploy also attempts to build. It is my understanding that it is a good measure to check build status before deploy.

[canac]

What scenario does this prevent against? If the build job would fail, wouldn't the yarn run build step in this deployment job fail also and abort the deployment anyway?

[zweatshirt]

That's true. It was my thought that that increases the time it takes for the workflow to process. If build fails, it didn't seem practical to re-run build in the deployment job despite failure. Maybe I am misunderstanding it. I guess it doesn't matter, since build will be flagged as fail anyway.

[canac]

That's a good point that it avoids rebuilding if the first build fails. Thanks for thinking of that improvement!

I'm thinking that this will make deployments slower though when the build succeeds. Now it will have to build, wait, then rebuild and deploy. Before the two builds could run in parallel and now they must run sequentially. I lean towards optimizing for the speed of deploying successful builds. Although in practice, building usually takes only ~15 seconds longer than running the tests, so this change wouldn't slow things down too much.

[dr-bizz]

In practice, I prefer that we have a successful build first before trying to deploy. I know this is happening anyway, as the deploy job runs a build.

I'm not fussed; I can go either way.

I will say our normal process is to build, and then once it's successful, we deploy. MPDX works this way.

Since we build on the CI when asking Amplify to deploy. Then Amplify runs a build to deploy.

[dr-bizz]

I don't mind the change Zach is requesting