Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EP-2569 - Fix border radius on Zip and State error labels #1184

Merged
merged 3 commits into from
Mar 19, 2025

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Mar 18, 2025

Descrition

In this PR, I fix the border-radius on the error labels from this PR #1182

@dr-bizz dr-bizz changed the base branch from master to 2362-okta March 18, 2025 21:09
@dr-bizz dr-bizz requested a review from canac March 18, 2025 21:09
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rules you added look great! Thanks for the quick work! I think that the organization could be improved a little bit. Let me know what you think.

@dr-bizz dr-bizz requested a review from canac March 19, 2025 13:53
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one minor suggestion and there is a merge conflict to resolve because I moved the line-height rule, but this looks good! Thanks for fixing it!

@dr-bizz dr-bizz merged commit c9091c5 into 2362-okta Mar 19, 2025
1 check passed
@dr-bizz dr-bizz deleted the 2362-okta-error-labels branch March 19, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants