Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-jira] update ruby 3.3.5 and rails 7.0.8.7 #26

Merged
merged 3 commits into from
Mar 24, 2025
Merged

Conversation

dbenton9
Copy link
Contributor

@dbenton9 dbenton9 commented Feb 5, 2025

In order to satisfy technical debt upgrade heroku I first need to update ruby and rails versions compatible with current heroky stacks.

This PR brings ruby up to 3.3.5 and rails to 7.0.8.7.

This is my first ever attempt at a ruby/rails upgrade but the app still runs locally. I'm taking that as a good sign 😅

Justin's Notes for Rails 7 upgrade

Rails 7 upgrades:

  • Gemfile updates from railsdiff.org
  • bundle update rails & fix dependencies
  • railsdiff for config/environments/development.rb
  • rails app:update
  • railsdiff
    • note if cookies_serializer.rb uses marshal, use hybrid instead (see new_framework_defaul)
    • leave package.json for now
  • add importmaps if needed: bin/rails importmap:install
    • pin JS dependencies: bin/importmap pin library@version
    • add to app/javascript/application.js
  • remove webpack files (contents of .gitignore, .iyarc, babel.config.js, package.json, postcss.config.js, yarn*, node_modules, config/webpack, config/webacker.yml, public/packs) https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#upgrading-from-rails-6-1-to-rails-7-0
    • button_to check (2.1)
    • encrypted cookies check (2.10)
    • ActiveStorage variants check (2.14)
  • Check for open redirects: (redirect_to , allow_other_host: true)
  • Check for link_to with method (switch to button_to or use turbo)
  • Add vips to dockerfile if necessary; remove imagemagick, nodejs, yarn
  • GHA workflow - remove yarn checks; add importmap audit

@dbenton9 dbenton9 self-assigned this Feb 5, 2025
@dbenton9 dbenton9 requested a review from jbirdjavi February 5, 2025 17:41
@dbenton9 dbenton9 changed the title update ruby 3.3.5 and rails 7.0.8.7 [no-jira] update ruby 3.3.5 and rails 7.0.8.7 Feb 5, 2025
@dbenton9 dbenton9 merged commit 7f68d58 into main Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants