Upgrade to Node 22 #878
Merged
Upgrade to Node 22 #878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canac
reviewed
Mar 28, 2025
canac
reviewed
Apr 10, 2025
|
I will clean up the commit after approval is completed. |
canac
reviewed
Apr 10, 2025
There was a problem hiding this comment.
Can you also update .node-version? That's the version that Netlify uses to build the site. Unfortunately, it's not smart enough to use .tool-versions, so we have to set it in both places.
Can we also update actions/checkout to v4? If I recall correctly, v2 was causing warnings about running on an old node version.
canac
approved these changes
Apr 10, 2025
…yarn as we don't track the cache in the repo.
…he, so there is no point having this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I have upgraded Node from version 18 to version 22. I have also upgraded Yarn to version 4. Yarn 4 has stricter rules around
--immutable-cache, causing us to remove it from the GitHub Actions.I have also updated the TS ESLint packages, as there was a warning message when running lint.
Changes:
node:18->22yarn:1->4@typescript-eslint/eslint-plugin:4->5@typescript-eslint/parser:4->5--immutable-cachefrom GHA. The way we could get this to pass is to track all .yarn/cachefolder, but this would bloat the repo and the only need for the cache files would be for the GHA, as we use node_modules.