-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to open contributor in new tab from Identities table cells #2738
Conversation
Signed-off-by: Sameh16 <[email protected]>
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe pull request modifies the Changes
Suggested reviewers
Possibly related PRs
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
frontend/src/modules/member/components/list/member-list-table.vue (1)
241-241
: Consider enabling an actual “open in new tab” behavior.Although the query parameter now preserves context for the
projectGroup
when navigating, it does not automatically open the link in a new browser tab. By default,<router-link>
navigates within the same tab. If the goal is to forcibly open a new tab directly from this table cell, you might need to replace or extend this<router-link>
usage with a standard anchor tag (<a>
) that includestarget="_blank"
andrel="noopener"
. Otherwise, relying on right-click or ctrl+click remains the user’s only way to open in a new tab.
Changes proposed ✍️
What
Allow to open contributor in new tab from Identities table cells
Checklist ✅
Feature
,Improvement
, orBug
.Summary by CodeRabbit