-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LFX-1481] Fix display of joined date in member merge dialog for unknown date #2648
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linting is failing
Addressing your review. View activity logs for details. |
@joanreyero I've addressed your review. Add another review if minor changes are needed. If major changes are needed, retry the issue from the Tusk app with additional context. |
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Signed-off-by: Sameh16 <[email protected]>
This PR addresses the issue where the joined date in the member merge dialog shows the fallback date '1970-01-01' when the joined date is unknown. The frontend code has been modified to display '-' instead of the fallback date.
The changes were made in the
member-merge-suggestions-details.vue
,member-model.js
, anddate-time-field.js
files to ensure that the display is corrected throughout the relevant components.Tips: