Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LFX-1157] Fix icon size issue in Connecting Integrations card #2646

Closed
wants to merge 2 commits into from
Closed

[LFX-1157] Fix icon size issue in Connecting Integrations card #2646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad957b0
fix(dashboard): maintain square shape of integration icons
use-tusk[bot] Oct 9, 2024
c9c1011
fix: address review from joanreyero
use-tusk[bot] Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions frontend/src/modules/dashboard/components/dashboard-integrations.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@
{{ segment.name }}
</p>
</div>
<article v-for="integration of segment.integrations" :key="`${segment.id}:${integration.platform}`" class="pb-4 flex w-full">
<div class="w-4 !min-w-4 mr-2 basis-4">
<img :alt="integration.platform" :src="CrowdIntegrations.getConfig(integration.platform)?.image" class="w-4 h-4 min-w-4">
<article v-for="integration of segment.integrations" :key="`${segment.id}:${integration.platform}`" class="pb-4 flex w-full items-start">
<div class="w-4 h-4 flex-shrink-0 mr-2">
<img :alt="integration.platform" :src="CrowdIntegrations.getConfig(integration.platform)?.image" class="w-full h-full object-contain">
</div>
<div class="-mt-px flex-grow">
<div class="flex-grow min-w-0">
<app-integration-progress-bar :progress="integration" />
</div>
</article>
Expand Down Expand Up @@ -89,3 +89,23 @@ export default {
name: 'LfDashboardIntegrations',
};
</script>

<style scoped>
.integration-icon-wrapper {
width: 16px;
height: 16px;
flex-shrink: 0;
margin-right: 8px;
}

.integration-icon {
width: 100%;
height: 100%;
object-fit: contain;
}

.integration-progress-wrapper {
flex-grow: 1;
min-width: 0;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep it in tailwind. we don't want to use any CSS

</style>
10 changes: 6 additions & 4 deletions frontend/src/modules/integration/components/integration-progress-bar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
<template>
<div v-if="props.progress && props.progress.reportStatus !== 'calculating'" class="flex flex-col justify-center w-full h-full">
<div v-if="!props.barOnly" class="flex justify-between items-center">
<p class="text-2xs text-gray-500 leading-4 pr-4">
<span v-if="inProgress?.message" v-html="inProgress?.message" />
<span v-else>Processing still in progress. Please wait for data stream updates.</span>
<div v-if="!props.barOnly" class="flex justify-between items-start">
<p class="text-2xs text-gray-500 leading-4 pr-4 flex-grow min-w-0">
<span class="block overflow-hidden text-ellipsis whitespace-nowrap">
<span v-if="inProgress?.message" v-html="inProgress?.message" />
<span v-else>Processing still in progress. Please wait for data stream updates.</span>
</span>
</p>

<el-popover :width="280" placement="top-end">
Expand Down
Loading