Remove OTEL tracing from our code #1886
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What we noticed so far is that sometimes, even though is no actual activity or work in the service, the services starts consuming all the CPU it has available. At the same time, the service doesn't actually do any other work during that time. If the service has, for instance, an express.js server, during that period it won't accept any requests at all.
Profiling the nodejs code in that state showed some grpc code being executed over and over, making me think it's OTEL.
What's worse is that this kind of state doesn't go away by itself, but requires a restart of the service.
Removing tracing proved to prevent this issue from appearing — no issues in
search-sync-apiandnodejs-workersince 15 hours.Keeping the tracing library in our code until later.