-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Android OnReceived condition virtual, fix UnsubscribeAll ios Bug and Update to new firebase sdk #444
base: master
Are you sure you want to change the base?
Conversation
Fixed a bug in FirebasePushNotificationManager.ios.cs. You loop thru currentTopics array in UnsubscribeAll and in the loop you remove items in currentTopics. Which results in an incomplete Unsubscribe operation. |
Hi @rdelrosario, |
@rdelrosario can we expect this change to be merged before June 2024? |
Hi @thomasgalliker , |
Ok cool. Its a nightmare to have to support .net maui and XF in one single project. I would rather publish a new nuget for xf (temporarily) until we have migrated to maui. Yet another nuget, I know what you think. The best solution would be to publish this changes here but it look like this plugin is no longer maintained…. |
@AlleSchonWeg did you publish these changes somewhere on nuget.org? We're stuck migrating one app to MAUI and I think we need an updated firebase-ios-sdk in order to publish apps to production. I'd create a new temporary nuget if you've not done so already. |
@thomasgalliker |
@AlleSchonWeg your PR actually triggered a build which created a nuget. That saves me for now, thanks! 🥇 |
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Feature
The condition to skip displaying a notification with android is confusing/complicated:
FirebasePushNotificationPlugin/Plugin.FirebasePushNotification/DefaultPushNotificationHandler.android.cs
Line 151 in d86266a
More infos: #434
🆕 What is the new behavior (if this is a feature change)?
With this change it is possible to implement a custom condition or simple skip the condition (return false). Just override the virtual method.
💥 Does this PR introduce a breaking change?
No.
🐛 Recommendations for testing
📝 Links to relevant issues/docs
🤔 Checklist before submitting