-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced array_get() with Arr::get(), array_get() removed in Laravel 6.0 #590
Open
webtamizhan
wants to merge
69
commits into
Crinsane:master
Choose a base branch
from
hardevine:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing links for - Storing the cart - Restoring the cart in Database section
fix links in Readme
Fixes the rounding issue for tax. See Crinsane#344
add save for later flag on cart item
added section about Buyable interface to README
links change
Add Buyable interface path to documentation
deleteStoredCart() added
restore wont delete stored cart
made $session protected
Fixes tax rounding issue
support L5.8
Update event->fire to event->dispatch
Update CartItem.php
Database query also check for instance
Support Laravel 7
toJson Method will return CartItem's model if available. so it can be used in Vue Component
Support laravel 7.0.8
Allow multiple taxrates
Update composer.json
toJson return with model if available
Fixed a bug where 0 is passed as the taxrate to the Cart:add facade resulting in it not evaluating right since '0' is not true in a if statement. Changed therefore the comparison to isset() so it rather checks if there is passed a taxrate of some kind. Also added in the if statement a simple check to see if the taxrate is numeric, and if not default to the one in the config
Update Cart.php
deleteStoredCart made 'public'
Fix MongoDB Driver issue Crinsane#478
Add support to Laravel 9
added support for laravel version 12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to be a breaking change in Laravel 6.0
6.0 - Uses the following
Arr::get($attributes, 'id', $this->id)
;instead of
array_get($attributes, 'id', $this->id);