Rq migration #301
Merged
Rq migration #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results 🚀601 tests +14 596 ✅ +13 2m 54s ⏱️ +20s For more details on these failures, see this check. Results for commit 1332cd4. ± Comparison against base commit b41e761. ♻️ This comment has been updated with latest results. |
arifBurakDemiray
requested review from
ArtursKadikis,
AliRKat,
ijunaid and
peterBrxwn
arifBurakDemiray
commented
May 7, 2024
peterBrxwn
approved these changes
May 8, 2024
turtledreams
requested changes
May 23, 2024
sdk/src/androidTest/java/ly/count/android/sdk/ModuleRemoteConfigTests.java
Show resolved
Hide resolved
| //String temporaryIdTag = "&device_id=" + DeviceId.temporaryCountlyDeviceId; | ||
|
|
||
| @NonNull String[] CreateInitialTmpIDState(@NonNull String did, @NonNull DeviceIdType dType, @NonNull String replaceDid, @NonNull CountlyStore cStore) { | ||
| String req1 = "aa=45&device_id=" + DeviceId.temporaryCountlyDeviceId; | ||
| String req2 = "12=qw&device_id=55"; | ||
| String req2 = "12=qw&device_id=55"; // this is a merge request and because of migration 9 that parameter is added |
turtledreams
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at to the MigrationHelperTests class to have an idea about what this migration must achieve
Tests PR - #306