Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a UsersList component and refactor #5259

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

aapeliv
Copy link
Member

@aapeliv aapeliv commented Nov 27, 2024

This builds on top of #5253 and #5254.

Creates a unified UsersList component that can be used in a bunch of places.

This is what it looks like:

simplescreenrecorder-2024-11-27_00.23.56.mp4

Web frontend checklist

  • Formatted my code with yarn format
  • There are no warnings from yarn lint --fix
  • There are no console warnings when running the app
  • Added any new components to storybook
  • Added tests where relevant
  • All tests pass
  • Clicked around my changes running locally and it works
  • Checked Desktop, Mobile and Tablet screen sizes

Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
couchers ✅ Ready (Inspect) Visit Preview Nov 27, 2024 5:11pm

@aapeliv aapeliv changed the title [Blocked] Clean up user lists [Blocked] Create a UsersList component and refactor Nov 27, 2024
@aapeliv aapeliv changed the base branch from develop to temp-base November 27, 2024 06:21
@aapeliv aapeliv changed the title [Blocked] Create a UsersList component and refactor Create a UsersList component and refactor Nov 27, 2024
@aapeliv aapeliv marked this pull request as ready for review November 27, 2024 06:41
@aapeliv aapeliv mentioned this pull request Nov 27, 2024
8 tasks
@aapeliv aapeliv changed the base branch from temp-base to develop November 27, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant