Backend/bugfix/4098 expired pending request showing new

[Krishnag09]

Backend checklist

• Formatted my code by running ruff check --select I --fix . && ruff check . && ruff format . in app/backend
• Added tests for any new code or added a regression test if fixing a bug
• All tests pass
• Run the backend locally and it works
• Added migrations if there are any database changes, rebased onto develop if necessary for linear migration history

Web frontend checklist

• Formatted my code with yarn format
• There are no warnings from yarn lint --fix
• There are no console warnings when running the app
• Added any new components to storybook
• Added tests where relevant
• All tests pass
• Clicked around my changes running locally and it works
• Checked Desktop, Mobile and Tablet screen sizes

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
couchers	✅ Ready (Inspect)	Visit Preview	Nov 23, 2024 5:05am

[aapeliv]

Which issue is this addressing?

I think it's better not to keep expiration state in the database explicitly. Then we'd need to keep updating it and have some background job to do it. It should be a computed field: if it's now past the end of the request, then it's expired.