Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend/feature/user search mega issue #4992

Open
wants to merge 26 commits into
base: develop
Choose a base branch
from

Conversation

Krishnag09
Copy link
Contributor

@Krishnag09 Krishnag09 commented Oct 15, 2024

added filter for language qualifying [fluent, conversational] for language abilities values as deemed to return user profiles.

Backend checklist

  • Formatted my code by running ruff check --select I --fix . && ruff check . && ruff format . in app/backend
  • Added tests for any new code or added a regression test if fixing a bug
  • All tests pass
  • Run the backend locally and it works
  • Added migrations if there are any database changes, rebased onto develop if necessary for linear migration history

Web frontend checklist

  • Formatted my code with yarn format
  • There are no warnings from yarn lint --fix
  • There are no console warnings when running the app
  • Added any new components to storybook
  • Added tests where relevant
  • All tests pass
  • Clicked around my changes running locally and it works
  • Checked Desktop, Mobile and Tablet screen sizes

Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
couchers ✅ Ready (Inspect) Visit Preview Nov 28, 2024 0:07am

Copy link
Member

@aapeliv aapeliv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK sorry, lots of comments that don't all make sense. Please ask further questions as needed! Also apologies for the slow review time!

app/backend/readme.md Outdated Show resolved Hide resolved
app/backend/readme.md Outdated Show resolved Hide resolved
app/backend/readme.md Outdated Show resolved Hide resolved
app/backend/src/couchers/servicers/search.py Show resolved Hide resolved
app/backend/src/couchers/servicers/search.py Outdated Show resolved Hide resolved
app/backend/src/couchers/servicers/search.py Outdated Show resolved Hide resolved
app/backend/src/tests/test_search.py Outdated Show resolved Hide resolved
app/proto/search.proto Outdated Show resolved Hide resolved
app/proto/search.proto Outdated Show resolved Hide resolved
app/backend/src/couchers/servicers/search.py Outdated Show resolved Hide resolved
Copy link
Member

@aapeliv aapeliv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry for the really long delay!

This is looking really close, just one minor change and there's a few unused bits of code here and there. But should be ready to merge otherwise!

app/backend/src/couchers/servicers/search.py Outdated Show resolved Hide resolved
app/backend/src/couchers/servicers/search.py Outdated Show resolved Hide resolved
app/backend/src/tests/test_search.py Outdated Show resolved Hide resolved
app/backend/src/tests/test_search.py Show resolved Hide resolved
app/proto/search.proto Outdated Show resolved Hide resolved
app/proto/search.proto Outdated Show resolved Hide resolved
@aapeliv
Copy link
Member

aapeliv commented Nov 25, 2024

@Krishnag09 let me know when you've addressed all review comments and this is good to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants