Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functional tests to check that COSMOS Http Works #3154

Closed
wants to merge 1 commit into from

Conversation

Muhammad-Noraeii
Copy link

I added a functional to test COSMOS Http

@Muhammad-Noraeii
Copy link
Author

@valentinbreiz
Please review it.

@Szymekk44
Copy link
Contributor

isin't http avaliable only with added cosmos http nugget?
Also what if mojox.org won't work..?

@valentinbreiz
Copy link
Member

valentinbreiz commented Mar 18, 2025

isin't http avaliable only with added cosmos http nugget?
Also what if mojox.org won't work..?

Hello yes but I suggested implementing the test cases under the cosmos testrunner instead of creating a new test engine in the CosmosHttp repo
See CosmosOS/CosmosHttp#2 (comment) for details

@Muhammad-Noraeii
Copy link
Author

@Szymekk44
Yes, But we need another server to test.

@valentinbreiz
What I have to do?
Where I have to put this code?
Here or COSMOS http ?

@valentinbreiz
Copy link
Member

@Szymekk44
Yes, But we need another server to test.

@valentinbreiz
What I have to do?
Where I have to put this code?
Here or COSMOS http ?

Here but be complient with other network tests (tcp, dns, dhcp...)

@Muhammad-Noraeii
Copy link
Author

Muhammad-Noraeii commented Mar 18, 2025

Ok but I searched most of tests and I didn't find network test

@valentinbreiz
Copy link
Member

valentinbreiz commented Mar 19, 2025

Ok but I searched most of tests and I didn't find network test

I sent you the links:

https://github.com/CosmosOS/Cosmos/blob/master/Tests/Kernels/NetworkTest/Kernel.cs. Here is the Kernel part but you could add an HTTP server in the test runner side (https://github.com/CosmosOS/Cosmos/blob/master/Tests/Cosmos.TestRunner.Core/Engine.Run.cs#L114 somewhere like here)

@Muhammad-Noraeii
Copy link
Author

Thanks.

@Muhammad-Noraeii
Copy link
Author

I think that I have to add code for test COSMOS Http to https://github.com/CosmosOS/Cosmos/blob/master/Tests/Kernels/NetworkTest/Kernel.cs
Is it ture?

@valentinbreiz
Copy link
Member

I think that I have to add code for test COSMOS Http to https://github.com/CosmosOS/Cosmos/blob/master/Tests/Kernels/NetworkTest/Kernel.cs Is it ture?

yes see how tcp test works

@Muhammad-Noraeii
Copy link
Author

I have a question,
How i can edit codes that I wrote there

@valentinbreiz
Copy link
Member

valentinbreiz commented Mar 19, 2025

I have a question, How i can edit codes that I wrote there

Just install git, clone your fork then go to patch-1 branch

PS: https://rogerdudler.github.io/git-guide/

@Muhammad-Noraeii
Copy link
Author

Ok thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants