Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Linq (Enumerable.cs) #3144

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Samma2009
Copy link

Added Linq, direct port from https://github.com/microsoft/referencesource/blob/master/System.Core/System/Linq/Enumerable.cs

it's a pull request out of time cus of gen3 but atleast it's something new and that cosmos needed

@zarlo
Copy link
Member

zarlo commented Feb 7, 2025

can you apply this patch to fix cicd

From 5ced6c3f0e2945719438aed7c70c1b1e75dc5f81 Mon Sep 17 00:00:00 2001
From: zarlo <5899@zarlo.dev>
Date: Fri, 7 Feb 2025 21:06:59 +0000
Subject: [PATCH] fix: update cicd

---
 .github/workflows/pr.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml
index d50a098ab..da4080b09 100644
--- a/.github/workflows/pr.yml
+++ b/.github/workflows/pr.yml
@@ -159,7 +159,7 @@ jobs:
           dotnet test "Cosmos\Tests\Cosmos.TestRunner.UnitTest\Cosmos.TestRunner.UnitTest.csproj" --logger "trx;LogFileName=$($env:USER_KIT_PATH)TestResults\${{ matrix.kernel }}-TestResult.trx" --filter "FullyQualifiedName~${{ matrix.kernel }}"
       
       - name: Upload Test Logs
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: test-logs
           path: ${{ env.USER_KIT_PATH }}TestResults
-- 
2.47.1

@zarlo the patch is applied
@zarlo zarlo enabled auto-merge February 7, 2025 21:25
@Samma2009
Copy link
Author

can you apply this patch to fix cicd

From 5ced6c3f0e2945719438aed7c70c1b1e75dc5f81 Mon Sep 17 00:00:00 2001
From: zarlo <5899@zarlo.dev>
Date: Fri, 7 Feb 2025 21:06:59 +0000
Subject: [PATCH] fix: update cicd

---
 .github/workflows/pr.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml
index d50a098ab..da4080b09 100644
--- a/.github/workflows/pr.yml
+++ b/.github/workflows/pr.yml
@@ -159,7 +159,7 @@ jobs:
           dotnet test "Cosmos\Tests\Cosmos.TestRunner.UnitTest\Cosmos.TestRunner.UnitTest.csproj" --logger "trx;LogFileName=$($env:USER_KIT_PATH)TestResults\${{ matrix.kernel }}-TestResult.trx" --filter "FullyQualifiedName~${{ matrix.kernel }}"
       
       - name: Upload Test Logs
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: test-logs
           path: ${{ env.USER_KIT_PATH }}TestResults
-- 
2.47.1

@zarlo done, the patch is applied

@zarlo
Copy link
Member

zarlo commented Feb 8, 2025

mmm it looks like cicd is still broken

@Samma2009
Copy link
Author

mmm it looks like cicd is still broken

Yep lol

@Lamparter
Copy link

v4 of the artifact workflows completely changes the way that they work.
Due to this, you can no longer have multiple files with the same name.
https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md#multiple-uploads-to-the-same-named-artifact

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants