Fix gRPC client

[masihyeganeh]

This change is 

[miladz68]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TxCorpi0x and @ysv)

[ysv]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TxCorpi0x)

[TxCorpi0x]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)

[ysv]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh)

---

.github/workflows/release.yml line 10 at r2 (raw file):

jobs:
  release:
    runs-on: ubuntu-24.04

I'm not sure what we should do for faucet.
maybe running on github-hosted runner ins still an option for faucet

If no then we should probably register our runners to be organization wide (not per repo as it is now)

maybe makes sense to check if it works if we run on ubuntu ?

[miladz68]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh)

[masihyeganeh]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ysv)

---

.github/workflows/release.yml line 10 at r2 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

I'm not sure what we should do for faucet.
maybe running on github-hosted runner ins still an option for faucet

If no then we should probably register our runners to be organization wide (not per repo as it is now)

maybe makes sense to check if it works if we run on ubuntu ?

I guess GitHub-hosted runners can run the CI for faucet. But I need this PR to merge, so I can test it

[ysv]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)

[masihyeganeh]

Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @masihyeganeh)

[masihyeganeh]

Reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)

[ysv]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)

[masihyeganeh]

Reviewed 16 of 16 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)

[masihyeganeh]

Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)

[masihyeganeh]

Reviewed 2 of 2 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)

[ysv]

Reviewed 16 of 16 files at r4, 2 of 2 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh)

---

client/coreum/batcher.go line 125 at r6 (raw file):

			_ = parallel.Run(ctx, func(ctx context.Context, spawn parallel.SpawnFn) error {
				for _, fundingAddress := range b.fundingAddresses {
					fundingAddress := fundingAddress

I'm not sure we should change this here
This was probably done on purpose

[TxCorpi0x]

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh)

[miladz68]

Reviewed 1 of 1 files at r3, 16 of 16 files at r4, 2 of 2 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh)

[masihyeganeh]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ysv)

---

client/coreum/batcher.go line 125 at r6 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

I'm not sure we should change this here
This was probably done on purpose

It was needed in older versions of Go. Not anymore.
Let me know if you think it is still needed.

[ysv]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)

---

client/coreum/batcher.go line 125 at r6 (raw file):

Previously, masihyeganeh (Masih Yeganeh) wrote…

It was needed in older versions of Go. Not anymore.
Let me know if you think it is still needed.

thanks, it is clear now