adding save_dir argument to decode_speech function, fix issue #117 #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paxtonfitzpatrick should i merge this pull request? and should we create a new release with the changes? |
|
also now adds a more permanent fix for #102 |
|
@jeremymanning I'm going to close this PR and open another from my fork's master branch. There are a few more updates I'd like to make before merging in changes and creating a new release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows the user to pass a path
save_dirtoquail.decode_speech(), specifying the output directory for the text file and pickled results object returned by Google Cloud Speech.Default behavior (
save_dir=None) is the same as current behavior of saving the transcript and results object to the same directory as the audio file being decoded.Also fixes issue #117