Skip to content

v0.5.1 (August 2018)

Compare
Choose a tag to compare
@andrewheusser andrewheusser released this 02 Aug 02:01
· 151 commits to master since this release
1bd82af
  • added flake8 to travis tests
  • refactored some of procrustes function code
  • removed support for python 3.4
  • removed hdbscan from dependencies (still can be used if installed manually)

Code cleanup (thanks @dwillmer!):

  • Changed string comparisons from if x is 'str' to if x == 'str'; the former is an identity comparison, not equality. It happens to be true for some strings because of string interning, but == should always be used for normal comparisons.
  • Removed unused arguments from _draw function - return_data and others weren't used in the function body.
  • Removed unreachable code in normalize function (branch criteria could never be True).
  • Separated out the multiply-nested function calls in DataGeometry class for clarity.
  • Changed comparisons of the formif type(x) is list to if isinstance(x, list); The former doesn't return True for subclasses, so isinstance should always be used.
  • Set unused loop variables to _.
  • Removed unused imports.
  • Ensured all imports are at the top of the file (except lazy / circular ones)
  • Ensure 2 blank lines above functions/classes (PEP8), the code looks a bit weird without this.
  • Fixed typo repect -> respect, was copy-pasted in multiple docstrings.
  • Removed redundant pass before error raise