merge with master #9068
Closed
merge with master #9068
+1,371
−1,455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Harris <[email protected]>
fixes #7955 Signed-off-by: Paul Harris <[email protected]>
Removed the SlashingProtectedValidatorSource todo as its had several PRs from bots, and it's actually grossly over-simplifying. Re-worded to remove TODO in EraFile, as its just a POC, and we won't be accepting any tiny changes there, the note was for when its rewritten. Removed the TODO from SszCollectionSchema but left the content, as it does seem valid. remove stale reference to a PR #3356 Fixes #7532 Signed-off-by: Paul Harris <[email protected]>
Using a plain ticket reference without TODO should still ensure we can track the issue. also added ticket reference for SszCollectionSchema.java Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
- also not sure that it's a good plan to not call assertOpen during setup of the streams, so asserted open in those fns. Signed-off-by: Paul Harris <[email protected]>
* remove unnecessary updater being passed around Signed-off-by: Gabriel Fukushima <[email protected]> --------- Signed-off-by: Gabriel Fukushima <[email protected]>
We had previously correctly renamed `GOSSIP_MAX_SIZE` but had not removed the `MAX_CHUNK_SIZE`. Signed-off-by: Paul Harris <[email protected]>
* remove unnecessary params being passed around Signed-off-by: Gabriel Fukushima <[email protected]> * remove updater creation from the `pruneOldestNonCanonicalBlobSidecars` Signed-off-by: Gabriel Fukushima <[email protected]> * spotless Signed-off-by: Gabriel Fukushima <[email protected]> * reuse the information stored in db variable to avoid streaming creating streaming from 0 all the time. Signed-off-by: Gabriel Fukushima <[email protected]> * spotless Signed-off-by: Gabriel Fukushima <[email protected]> * add optimization on block pruner Signed-off-by: Gabriel Fukushima <[email protected]> * use getEarliestFinalizedBlockSlot which is optimized rather than getEarliestFinalizedBlock Signed-off-by: Gabriel Fukushima <[email protected]> * spotless Signed-off-by: Gabriel Fukushima <[email protected]> * reverse order of services shutdown Signed-off-by: Gabriel Fukushima <[email protected]> * spotless Signed-off-by: Gabriel Fukushima <[email protected]> * spotless Signed-off-by: Gabriel Fukushima <[email protected]> * Revert "reuse the information stored in db variable to avoid streaming creating streaming from 0 all the time." This reverts commit 0ca062a Signed-off-by: Gabriel Fukushima <[email protected]> * reverting commit that broke tests Signed-off-by: Gabriel Fukushima <[email protected]> * add check to avoid invalid stream params Signed-off-by: Gabriel Fukushima <[email protected]> * git went crazy here Signed-off-by: Gabriel Fukushima <[email protected]> * add check to prevent invalid range in stream Signed-off-by: Gabriel Fukushima <[email protected]> * PR review Signed-off-by: Gabriel Fukushima <[email protected]> * remove logger Signed-off-by: Gabriel Fukushima <[email protected]> * resolve conflicts Signed-off-by: Gabriel Fukushima <[email protected]> --------- Signed-off-by: Gabriel Fukushima <[email protected]>
* Remove TTD Bellatrix merge configuration option * Fix test for earlier throw than before on PowBlockMonitor * Fix acceptance tests + remove outdated bellatrix merge * Deprecate TTD reference tests * Remove TTD option in ExecutionLayerChannelStub --------- Co-authored-by: Enrico Del Fante <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
- looking at 4104 in consensus-specs, its relatively simple to change our processRegistryUpdates to do this. Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog