Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RocksdbStats should only create summary if database is open #9066

Merged
merged 2 commits into from
Jan 31, 2025
Merged

RocksdbStats should only create summary if database is open #9066

merged 2 commits into from
Jan 31, 2025

Conversation

rolfyone
Copy link
Contributor

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

gfukushima
gfukushima approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@gfukushima gfukushima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rolfyone rolfyone merged commit 7bf58da into Consensys:master Jan 31, 2025
16 checks passed
@rolfyone rolfyone deleted the rocksdb-stats branch January 31, 2025 04:32
@gfukushima gfukushima mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfukushima gfukushima gfukushima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rolfyone @gfukushima