testnet config updates #9049
Merged
testnet config updates #9049
+17
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Harris <paul.harris@consensys.net>
tbenr
reviewed
Jan 28, 2025
ethereum/spec/src/main/resources/tech/pegasys/teku/spec/config/configs/holesky.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Paul Harris <paul.harris@consensys.net>
… one, so hopefully that gets accepted. Signed-off-by: Paul Harris <paul.harris@consensys.net>
lucassaldanha
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
LGTM. Do we need to wait for https://github.com/eth-clients/holesky/pull/119/files before merging this?
|
makes sense to wait |
|
either/or. We can wait in case the dates change, thats fine. |
|
They are indeed changing |
Signed-off-by: Paul Harris <paul.harris@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found some holesky fields missing also and raised a PR on holesky testnet config.
addresses ethereum/pm#1265
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog