Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to toggle on/off IP Validation in Enhanced Permissioing NodeManager. #1677

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

john-sobrepena-partior
Copy link

@john-sobrepena-partior john-sobrepena-partior commented Sep 19, 2023

Use case
We are running a 1st Quorum node in kubernetes pod with Enhanced Permissioning v2 enabled. A 2nd quorum node is hosted in another kubernetes cluster / namespace also running Enhanced Permissioning v2. The 1st and 2nd quorum node's enodeIds, ports and IP addresses were added to the list of nodes that are allowed to connect. The geth API quorumPermission_addNode() was used.
However, the 1st and 2nd node are not able to connect to each other because, for example - the incoming connection from 2nd node's IP has changed. Based on discussion with our infra team, and due to securities in place, the IP address of incoming connection may change or re-written before the connection request finally reach the pod where the other Quorum node is running. Due to this, the connectionAllowed() of v2/contract/NodeManager.sol rejects the connection.

Proposed Solution / Changes
I am proposing in this change to introduce a setIpValidation() function in NodeManager.sol to toggle IP validation on or off. This is enabled by default. The property can only be set before network boot status is finalized.

For your review / comments. Let me know if you require further information. I will be more than happy to provide them and to help contribute further. I look forward working with you.

Thank you in advance.

Regards, John

…s is anebaled by default. This can be set before network boot status is finalized.
@CLAassistant
Copy link

CLAassistant commented Sep 19, 2023

CLA assistant check
All committers have signed the CLA.

@john-sobrepena-partior
Copy link
Author

Hi @antonydenyer, kindly help look into and review my proposed changes for Enhanced Permissioning v2. Let me know any further clarifications required. Thank you in advance.

Regards, John

@john-sobrepena-partior john-sobrepena-partior changed the title Added function to toggle on/off IP Validation in Enhanced Permissioing NodeManager. Add function to toggle on/off IP Validation in Enhanced Permissioing NodeManager. Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants