clean: some cleaning in GAS, EUC, EXP #2483
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: F Bojarski <[email protected]>
Signed-off-by: F Bojarski <[email protected]>
Signed-off-by: F Bojarski <[email protected]>
Signed-off-by: F Bojarski <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| this.dividend = dividend; | ||
| this.divisor = divisorTrim; | ||
| this.dividend = dividend.trimLeadingZeros(); | ||
| this.divisor = divisorTrim.trimLeadingZeros(); |
There was a problem hiding this comment.
Bug: Optimize Divisor Field Trimming
The divisor field is trimmed twice: divisorTrim already contains the result of divisor.trimLeadingZeros() from line 38, so calling trimLeadingZeros() again on it is redundant. The assignment should be this.divisor = divisorTrim; to match the original behavior and avoid unnecessary computation.
Signed-off-by: F Bojarski <[email protected]>
letypequividelespoubelles
changed the title
| this.dividend = dividend; | ||
| this.divisor = divisorTrim; | ||
| this.dividend = dividend.trimLeadingZeros(); | ||
| this.divisor = divisorTrim.trimLeadingZeros(); |
There was a problem hiding this comment.
Bug: Unnecessary Trimming Impacts Performance
The divisor field is trimmed twice: once when creating divisorTrim at line 38, then again when assigning to this.divisor. This redundant operation wastes CPU cycles. The assignment should be this.divisor = divisorTrim; to match the pattern used for quotient at line 43.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Decouples
EUCfromWcp, simplifiesGasinvocation, refinesEXPconstants, refactorsStpCall, adds an EXP duplicate test, and bumps the release version.EUC: RemoveWcpdependency; instantiate vianew Euc()inZkCounter/Hub; dropwcp.callLTand simplifycallEUC; trimdividend/divisorinEucOperation.Gas: Simplify API tocall(Hub, CommonFragmentValues); internally createGasParameters; update trigger inCommonFragmentValues.WORD_SIZEfor cutoffs inExpOperation(replacing hardcoded32).StpCall: refactor to useopCodeData.mnemonic()and passframe/opCodeto helpers; minor cleanups.ZkCounter: constructEucwithoutWcp.ExpTest.testExpLogDuplicate.releaseVersioningradle.properties.Written by Cursor Bugbot for commit 564f95d. This will update automatically on new commits. Configure here.