feat: make jar release condition to unit and replay passing by default' #2469
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
amkCha
force-pushed
the
feat/unit-replays-condition-to-jar-release
branch
from
9107e69 to
eb7d3d9
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
amkCha
force-pushed
the
feat/unit-replays-condition-to-jar-release
branch
from
eb7d3d9 to
44987a2
Compare
amkCha
force-pushed
the
feat/unit-replays-condition-to-jar-release
branch
from
ba3d69d to
21e472d
Compare
DavePearce
left a comment
DavePearce
left a comment
There was a problem hiding this comment.
Overall, looks fine. There is a comment from Cursor which I think should be addressed. The manual release either needs a tests-with-ssh or perhaps more easily just set it to false where its used.
.github/workflows/manual-release.yml
Outdated
| # ================================================================== | ||
| # Publish release post tests | ||
| # ================================================================== | ||
| publish-conditional-to-units-and-replay-tests: |
There was a problem hiding this comment.
Not sure about the name here. This should be the default path, right? So I would just call it publish or perhaps publish-default.
amkCha
force-pushed
the
feat/unit-replays-condition-to-jar-release
branch
from
21e472d to
9b7a84b
Compare
amkCha
force-pushed
the
feat/unit-replays-condition-to-jar-release
branch
from
9b7a84b to
03b6fea
Compare
| # Publish release post tests | ||
| # ================================================================== | ||
| publish-default: | ||
| needs: [ build, unit-tests-prague, replay-tests ] |
There was a problem hiding this comment.
Bug: Publishing Ignores Critical Test Failures
The publish-default job waits for unit-tests-prague and replay-tests but not unit-tests-cancun, even though CANCUN tests are defined and run. This means publishing can proceed even if CANCUN tests fail, which contradicts the PR's intent to make releases conditional on all unit and replay tests passing.
Note
Make releases publish only after unit and fast replay tests by default, add a reusable fast replay workflow, and refactor CI to consume it.
./.github/workflows/reusable-fast-replay-tests.ymlto run:arithmetization:fastReplayTestsand upload reports/artifacts..github/workflows/gradle-tests.yml):replay-testsjob with call toreusable-fast-replay-tests.yml.tests-with-sshto unit and replay tests..github/workflows/manual-release.yml):wait-for-tests-bef-publishandtests-with-ssh.publish-default: waits for tests (default) before./gradlew publishwith Cloudsmith creds.publish-as-soon-as-ready: publishes immediately whenwait-for-tests-bef-publishisfalse.Written by Cursor Bugbot for commit 03b6fea. This will update automatically on new commits. Configure here.