-
Notifications
You must be signed in to change notification settings - Fork 46
clean: rm unused duplicate traceStartBlock in ZkTracer #2374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: arith-dev
Are you sure you want to change the base?
clean: rm unused duplicate traceStartBlock in ZkTracer #2374
Conversation
Signed-off-by: F Bojarski <[email protected]>
Signed-off-by: F Bojarski <[email protected]>
Signed-off-by: F Bojarski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Transaction Commit Issue in WCP Module
The removal of traceStartBlock in Wcp.java means additionalRows.commitTransactionBundle() is no longer called at block start. This prevents additionalRows from properly committing its state, potentially causing incorrect line counting and state management in the WCP module.
arithmetization/src/main/java/net/consensys/linea/zktracer/module/wcp/Wcp.java#L91-L110
linea-tracer/arithmetization/src/main/java/net/consensys/linea/zktracer/module/wcp/Wcp.java
Lines 91 to 110 in d39cad4
| additionalRows.commitTransactionBundle(); | |
| } | |
| @Override | |
| public void popTransactionBundle() { | |
| for (ModuleOperationStackedSet<WcpOperation> operationsSet : operations) { | |
| operationsSet.popTransactionBundle(); | |
| } | |
| additionalRows.popTransactionBundle(); | |
| } | |
| @Override | |
| public void tracePreOpcode(MessageFrame frame, OpCode opcode) { | |
| if (opcode == LT | |
| || opcode == GT | |
| || opcode == SLT | |
| || opcode == SGT | |
| || opcode == EQ | |
| || opcode == ISZERO) { | |
Note
Remove ProcessableBlockHeader-based traceStartBlock overload, consolidating on (BlockHeader, BlockBody) signature and updating Wcp module and tests accordingly.
traceStartBlock(WorldView, ProcessableBlockHeader, Address)fromZkTracerandWcp; usetraceStartBlock(WorldView, BlockHeader, BlockBody, Address).LineCountingTracerTestandBlockchainReferenceTestToolsto passBlockBody(e.g.,BlockBody.empty()orblock.getBody()).BlockBodyimports and adjust method invocations.Written by Cursor Bugbot for commit d39cad4. This will update automatically on new commits. Configure here.