Skip to content

Conversation

@thedarkjester
Copy link
Collaborator

@thedarkjester thedarkjester commented Nov 14, 2025

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

Note

Updates BlobSubmission tests to use Prover Beta v4.3 data, verifiers, and paths for Sepolia and Mainnet.

  • Tests (BlobSubmission.ts):
    • Switch imports and test data from betaV4_1_* to betaV4_3_* for Sepolia and Mainnet.
    • Update verifier factories to src/verifiers/beta-v4.3/* contracts.
    • Rename variables and references from betaV4_1_* to betaV4_3_* throughout.
    • Adjust blob file paths (getVersionedBlobFiles) and file reads to betaV4_3_* directories.
    • Update finalization inputs and expected event/assertion values to match v4.3 datasets.

Written by Cursor Bugbot for commit ae653a6. This will update automatically on new commits. Configure here.

@thedarkjester thedarkjester requested a review from a team as a code owner November 14, 2025 16:27
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.67%. Comparing base (cbf344e) to head (ae653a6).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1737   +/-   ##
=========================================
  Coverage     65.67%   65.67%           
  Complexity     1522     1522           
=========================================
  Files           389      389           
  Lines         14117    14117           
  Branches       1454     1454           
=========================================
  Hits           9271     9271           
  Misses         4236     4236           
  Partials        610      610           
Flag Coverage Δ *Carryforward flag
hardhat 96.20% <ø> (ø)
kotlin 63.27% <ø> (ø) Carriedforward from cbf344e

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...s/src/verifiers/beta-v4.3/PlonkVerifierMainnet.sol 100.00% <ø> (ø)
...s/src/verifiers/beta-v4.3/PlonkVerifierSepolia.sol 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants