Refactor/message update #1648
Open
Refactor/message update #1648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| await mockDashboard.setWithdrawableValueReturn(stakingVaultBalance); | ||
| await yieldManager.connect(nonAuthorizedAccount).replenishWithdrawalReserve(yieldProviderAddress); | ||
|
|
||
| expect(await getBalance(mockStakingVault)).eq(stakingVaultBalance - stakingVaultBalance); |
Check warning
Code scanning / CodeQL
Identical operands Warning test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 17 days ago
To fix the problem, replace stakingVaultBalance - stakingVaultBalance with 0 in the assertion at line 931. This is a simple substitution, as the subtraction of a value from itself always yields zero and does not change the intent or functionality of the test. No other code, imports, or logic needs to change.
Suggested changeset
1
contracts/test/hardhat/yield/integration/YieldManager.integration.ts
| @@ -928,7 +928,7 @@ | ||
| await mockDashboard.setWithdrawableValueReturn(stakingVaultBalance); | ||
| await yieldManager.connect(nonAuthorizedAccount).replenishWithdrawalReserve(yieldProviderAddress); | ||
|
|
||
| expect(await getBalance(mockStakingVault)).eq(stakingVaultBalance - stakingVaultBalance); | ||
| expect(await getBalance(mockStakingVault)).eq(0); | ||
| expect(await getBalance(lineaRollup)).eq(l1MessageServiceBalance + stakingVaultBalance); | ||
|
|
||
| // Kick off ossification |
Copilot is powered by AI and may make mistakes. Always verify output.
* natspec tweaks * minor tweaks * more tweaks --------- Signed-off-by: kyzooghost <[email protected]> Co-authored-by: kyzooghost <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements issue(s) #
Checklist
Note
Introduces a full native-yield system (YieldManager + Lido StVault provider/factory) integrated with LineaRollup, including permissioned/permissionless unstaking, LST withdrawals, ossification flow, and on-chain EIP-4788 validator proof verification, with extensive tests and role/pause updates.
YieldManager(+ storage/layout/base) with funding, yield reporting, (permissioned/permissionless) unstake, LST withdrawals, reserve management, and ossification controls.LidoStVaultYieldProviderandLidoStVaultYieldProviderFactory, plus Lido vendor interfaces (IDashboard,IStakingVault,IVaultHub, etc.).ValidatorContainerProofVerifierand supporting libs (SSZ,BLS,GIndex) for EIP-4788 active validator proofing.LineaRollup(v7 reinit) to setyieldManager, transfer funds, emit synthetic yield messages, and supportclaimMessageWithProofAndWithdrawLST.PlonkVerifierSepoliaFull; dependency updates (e.g.,@chainsafe/blst).Written by Cursor Bugbot for commit 3ed10b7. This will update automatically on new commits. Configure here.