fix: improve AssertIsCrumb readability and add constant check #1650
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add constant value check at the start of AssertIsCrumb to avoid unnecessary constraint generation for compile-time constants.
Use separate variable x instead of overwriting input parameter for better code clarity.
Add mathematical comment explaining the polynomial constraint derivation, matching the SCS implementation style.
Note
Optimize and clarify
AssertIsCrumbby adding a constant fast path, cleaner polynomial constraint with auxiliary variable, and explanatory comment.frontend/cs/r1cs/api_assertions.go):AssertIsCrumb:[0,3], panic otherwise with clearer error message.x := i1² - 3i1, enforcingx(x+2) = 0without mutating the input.Written by Cursor Bugbot for commit 8a7ffdb. This will update automatically on new commits. Configure here.